New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space leak in ./Setup configure #3076

Merged
merged 1 commit into from Jan 26, 2016

Conversation

Projects
None yet
3 participants
@grayjay
Copy link
Collaborator

grayjay commented Jan 26, 2016

This commit fixes the space leak in #2777 without modifying the logic for choosing flags. It is a lot simpler than #2925, though I think an improvement to the algorithm like in #2925 is still needed. I tested the practicality of solving for more flags by running ./Setup configure on git-annex with 3 of the 21 flags removed. Most of the dependencies were missing, which meant that Setup had to try all 2^18 flag combinations. It took 13 minutes.

/cc @joeyh

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Jan 26, 2016

Travis failure is unrelated to your change (see #3003).

@joeyh

This comment has been minimized.

Copy link

joeyh commented Jan 26, 2016

Incidentally, git-annex HEAD is down to 16 flags;
under 10 minutes worst case for Setup configure is fine by me.

see shy jo

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Jan 26, 2016

LGTM, merging. Sorry for taking so long!

23Skidoo added a commit that referenced this pull request Jan 26, 2016

Merge pull request #3076 from grayjay/setup-configure-space-leak
Fix space leak in ./Setup configure

@23Skidoo 23Skidoo merged commit 500ccce into haskell:master Jan 26, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@grayjay

This comment has been minimized.

Copy link
Collaborator

grayjay commented Jan 27, 2016

@23Skidoo No problem. Thanks for merging it.

@grayjay grayjay deleted the grayjay:setup-configure-space-leak branch Jan 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment