New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on -v0 to GHC. #3671

Merged
merged 1 commit into from Aug 6, 2016

Conversation

Projects
None yet
3 participants
@ezyang
Copy link
Contributor

ezyang commented Aug 5, 2016

Signed-off-by: Edward Z. Yang ezyang@cs.stanford.edu

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Aug 5, 2016

@ezyang, thanks for your PR! By analyzing the annotation information on this pull request, we identified @23Skidoo, @dcoutts and @luite to be potential reviewers

@@ -272,8 +273,9 @@ componentGhcOptions :: Verbosity -> LocalBuildInfo
-> GhcOptions
componentGhcOptions _verbosity lbi bi clbi odir =

This comment has been minimized.

@23Skidoo

23Skidoo Aug 5, 2016

Member

s/_verbosity/verbosity/

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Aug 5, 2016

LGTM.

@ezyang ezyang force-pushed the ezyang:pr/handle-v0 branch from cf7dd67 to 49d628e Aug 5, 2016

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Aug 5, 2016

Related: #3540.

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Aug 6, 2016

Still fails to compile:

Distribution/Client/SetupWrapper.hs:629:39: Not in scope: `toFlag'

Distribution/Client/SetupWrapper.hs:629:61: Not in scope: `normal'
Pass on -v0 to GHC.
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

@ezyang ezyang force-pushed the ezyang:pr/handle-v0 branch from 49d628e to e3fd8c8 Aug 6, 2016

@ezyang ezyang merged commit a92bfc8 into haskell:master Aug 6, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment