New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new-bench actually run the benchmarks #4614

Merged
merged 4 commits into from Jul 25, 2017

Conversation

Projects
2 participants
@fgaz
Collaborator

fgaz commented Jul 20, 2017

Based on new-test.

  • Review myself the changes, since it was all pretty much automatic.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Tests.
@23Skidoo

This comment has been minimized.

Show comment
Hide comment
@23Skidoo

23Skidoo Jul 21, 2017

Member

Code looks OK from what I can tell.

Member

23Skidoo commented Jul 21, 2017

Code looks OK from what I can tell.

@fgaz

This comment has been minimized.

Show comment
Hide comment
@fgaz

fgaz Jul 25, 2017

Collaborator

@23Skidoo
Is tahat "blocked: action required" tag for the bug? That's not strictly bench-related, so can I merge anyway?

Collaborator

fgaz commented Jul 25, 2017

@23Skidoo
Is tahat "blocked: action required" tag for the bug? That's not strictly bench-related, so can I merge anyway?

@23Skidoo

This comment has been minimized.

Show comment
Hide comment
@23Skidoo

23Skidoo Jul 25, 2017

Member

@fgaz Your PR wasn't complete when I added that tag, but now it looks good to go.

Member

23Skidoo commented Jul 25, 2017

@fgaz Your PR wasn't complete when I added that tag, but now it looks good to go.

@fgaz fgaz merged commit e523b19 into haskell:master Jul 25, 2017

13 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linux-7.10.3 Downstream Travis
Details
linux-7.4.2 Downstream Travis
Details
linux-7.6.3 Downstream Travis
Details
linux-7.8.4 Downstream Travis
Details
linux-8.0.2 Downstream Travis
Details
linux-8.0.2-fdebug-expensive-assertions Downstream Travis
Details
linux-8.0.2-parsec Downstream Travis
Details
linux-8.2.1 Downstream Travis
Details
osx-7.10.3 Downstream Travis
Details
osx-7.8.4 Downstream Travis
Details
osx-8.0.2 Downstream Travis
Details

@fgaz fgaz moved this from current to done in Last Mile for `cabal new-build` (HSOC2017) Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment