Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Separate GenericPackageDescription from PackageDescription #5100

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Ericson2314
Copy link
Collaborator

commented Feb 2, 2018

Now, neither contains the other, and their common fields are contained in 'CommonPackageDependencies'.

I'll probably first merge a change adding lenses per components, so some stuff can be made {Generic,}PackageDescription-polymorphic in advance. (The lenses would of course preserve the cond tree structure.)

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

CC @kmicklas

@Ericson2314 Ericson2314 requested review from phadej and hvr Feb 2, 2018

@Ericson2314

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 2, 2018

BTW, how do I get pems to cancel AppVeyor build?

@23Skidoo

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

AppVeyor has underdeveloped account structure that doesn't map to GitHub orgs, but I remember that @hvr managed to do it by logging in to AppVeyor using my user name somehow.

@Ericson2314 Ericson2314 force-pushed the Ericson2314:separate-pkg-desc branch from 5eaff31 to ac30a62 Feb 9, 2018

@Ericson2314 Ericson2314 force-pushed the Ericson2314:separate-pkg-desc branch 2 times, most recently from 7a40f92 to 854b2fd Feb 14, 2018

Ericson2314 added some commits Feb 2, 2018

Separate GenericPackageDescription from PackageDescription
Now, neither contains the other, and their common fields are contained
in 'CommonPackageDependencies'.
Add traversals for components
This could maybe use used to clean up PD checking and make it polymorphic on PD and GPD.

@Ericson2314 Ericson2314 added this to the 3.0 milestone Aug 20, 2018

@Ericson2314 Ericson2314 force-pushed the Ericson2314:separate-pkg-desc branch from 854b2fd to b205790 Oct 25, 2018

@Ericson2314 Ericson2314 force-pushed the Ericson2314:separate-pkg-desc branch from b205790 to b3d2220 Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.