Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `cabal get --only-package-description` #5162

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@hvr
Copy link
Member

hvr commented Feb 24, 2018

With this option, 'cabal get' writes to the destination directory only the
package description already available locally in one of the repository
indices.

The basename of the file name written to inside the target directory is
the package-id rather than only the package name.

This is mostly based on #1977

Co-authored-by: Miëtek Bak mietek@bak.io


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

Add `cabal get --only-package-description`
With this option, 'cabal get' writes to the destination directory only the
package description already available locally in one of the repository
indices.

The basename of the file name written to inside the target directory is
the package-id rather than only the package name.

This is mostly based on #1977

Co-authored-by: Miëtek Bak <mietek@bak.io>
@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Feb 24, 2018

Looks all right on a first glance, but needs docs; this is the relevant manual section: https://cabal.readthedocs.io/en/latest/developing-packages.html#downloading-a-package-s-source

@hvr

This comment has been minimized.

Copy link
Member Author

hvr commented Feb 24, 2018

@23Skidoo just asking for the changelog-entry, is this 2.2 material or post-2.2 ?

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Feb 24, 2018

I think it's low risk, we can merge it into 2.2.

@hvr

This comment has been minimized.

Copy link
Member Author

hvr commented Feb 24, 2018

@23Skidoo fwiw; I still need to get --pristine working -- --index-state already works out of the box, but --pristine doesn't yet (this is what blocked #1977 from getting merged originally). Depending on how I go about this, this may actually be more invasive than would be justifiable for 2.2 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.