Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verifyGenericPackageDescription #5205

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@phadej
Copy link
Collaborator

commented Mar 13, 2018

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@phadej phadej requested a review from hvr Mar 13, 2018

verifyGenericPackageDecsription gpd = do
-- TODO: currently there aren't any checks, but this is where they can be added.
-- Note: if we will check that used flags are the ones declared,
-- we can do that already in parseCondTree: then errors will have a correct position.

This comment has been minimized.

Copy link
@hvr

hvr Mar 13, 2018

Member

so... how does one fail here? e.g. let's assume an undeclared flag use-site is detected; how do I throw an error pointing to the use-site of the unknown flag?

This comment has been minimized.

Copy link
@phadej

phadej Mar 14, 2018

Author Collaborator

@hvr with parseFailure. As the comment implies, at this point we don't have positions attached, so we can only parseFailure zeroPos.

Let's do better flag handling as a follow-up or an alternative.

This comment has been minimized.

Copy link
@phadej

phadej Mar 14, 2018

Author Collaborator

Note to previous: Unfortunately we might need to do some trickery-pockery, as flag may be declared after it's usage, if someone puts flag stanza after library. This is slight :/

@23Skidoo

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

Looks like CI failures are due to -Wall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.