Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning message for cabal-version field (see #5108) #5230

Merged
merged 2 commits into from Mar 26, 2018
Merged

Fix warning message for cabal-version field (see #5108) #5230

merged 2 commits into from Mar 26, 2018

Conversation

lspitzner
Copy link
Collaborator

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@23Skidoo
Copy link
Member

Looks like the test suite needs to be fixed up (expected output is now wrong).

23Skidoo
23Skidoo approved these changes Mar 25, 2018
View reviewed changes
Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@23Skidoo 23Skidoo merged commit 4b72242 into master Mar 26, 2018
@23Skidoo 23Skidoo deleted the lspitzner-patch-1 branch March 26, 2018 00:13
@23Skidoo
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@23Skidoo 23Skidoo 23Skidoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lspitzner @23Skidoo