New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal new-clean #5357

Merged
merged 1 commit into from Jun 11, 2018

Conversation

@typedrat
Collaborator

typedrat commented Jun 1, 2018

I think it needs some clean-up most likely, but by my understanding of what it's supposed to do, it's at least feature complete.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!


Fixes #2957

@dcoutts

Looks ok, but I think that because we extend the install command, this will give the new-clean command a bazillion flags that are effectively unused and so unnecessary.

Have a look at the project orchestration module and see if we can get ahold of a dist dir layout without needing much more than the GlobalFlags.

Show outdated Hide outdated cabal-install/Distribution/Client/CmdClean.hs Outdated
Show outdated Hide outdated cabal-install/Distribution/Client/CmdClean.hs Outdated
@typedrat

This comment has been minimized.

Show comment
Hide comment
@typedrat

typedrat Jun 1, 2018

Collaborator

@dcoutts I know this was covered in IRC but just for others/posterity, the reason it's like that is to support removing individual targets, which requires knowing most of the build information.

Collaborator

typedrat commented Jun 1, 2018

@dcoutts I know this was covered in IRC but just for others/posterity, the reason it's like that is to support removing individual targets, which requires knowing most of the build information.

@typedrat

This comment has been minimized.

Show comment
Hide comment
@typedrat

typedrat Jun 6, 2018

Collaborator

Huh, was when exported from somewhere else but only in 7.10.3? I'm trying to figure out why that CI error is showing up.

Collaborator

typedrat commented Jun 6, 2018

Huh, was when exported from somewhere else but only in 7.10.3? I'm trying to figure out why that CI error is showing up.

@typedrat

This comment has been minimized.

Show comment
Hide comment
@typedrat

typedrat Jun 8, 2018

Collaborator

Do we want to keep the wildly argumentative new-clean that allows selective cleaning (and refine that feature so it works better than it does now) or do we give up on that functionality to be able to simplify the flags it will take?

Even dropping the functionality, there are a few things that we can't get around being able to know (unless we want to only support default use): dist dir prefix and project file name. That's not that bad, though.

Collaborator

typedrat commented Jun 8, 2018

Do we want to keep the wildly argumentative new-clean that allows selective cleaning (and refine that feature so it works better than it does now) or do we give up on that functionality to be able to simplify the flags it will take?

Even dropping the functionality, there are a few things that we can't get around being able to know (unless we want to only support default use): dist dir prefix and project file name. That's not that bad, though.

@typedrat

This comment has been minimized.

Show comment
Hide comment
@typedrat

typedrat Jun 8, 2018

Collaborator

I like that a lot better, and personally I don't know if the trade-off in complexity is worth it. If it's going to know how to map a target into the information it needs to clean things up, it'll need to know enough to build stuff.

Collaborator

typedrat commented Jun 8, 2018

I like that a lot better, and personally I don't know if the trade-off in complexity is worth it. If it's going to know how to map a target into the information it needs to clean things up, it'll need to know enough to build stuff.

Made changes in question, no longer uses the complex UI.

@typedrat

This comment has been minimized.

Show comment
Hide comment
@typedrat

typedrat Jun 9, 2018

Collaborator

It is now properly documented, and unless we really want target-specific cleaning enough to add the substantial complexity increase, I believe this just needs squashing and merging.

Collaborator

typedrat commented Jun 9, 2018

It is now properly documented, and unless we really want target-specific cleaning enough to add the substantial complexity increase, I believe this just needs squashing and merging.

@typedrat typedrat moved this from In Progress to Done in Have new-build become build (GSOC2018) Jun 9, 2018

@23Skidoo

This comment has been minimized.

Show comment
Hide comment
@23Skidoo

23Skidoo Jun 10, 2018

Member

I agree that granular clean is not required for 3.0, for which our main goal is feature parity.

Member

23Skidoo commented Jun 10, 2018

I agree that granular clean is not required for 3.0, for which our main goal is feature parity.

@23Skidoo

Code LGTM, but I'd like the documentation to explicitly list the supported flags, especially --save-config.

Show outdated Hide outdated Cabal/doc/nix-local-build.rst Outdated
Show outdated Hide outdated cabal-install/changelog Outdated

@typedrat typedrat merged commit e5f8dc3 into haskell:master Jun 11, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@quasicomputational

This comment has been minimized.

Show comment
Hide comment
@quasicomputational

quasicomputational Jun 11, 2018

Collaborator

Oh, changelog note? Actually I'll go ahead and write one up myself.

Collaborator

quasicomputational commented Jun 11, 2018

Oh, changelog note? Actually I'll go ahead and write one up myself.

@typedrat typedrat changed the title from [WIP!] cabal new-clean to cabal new-clean Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment