New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate selectors by the command being used #5461

Merged
merged 3 commits into from Jul 27, 2018

Conversation

Projects
2 participants
@typedrat
Collaborator

typedrat commented Jul 27, 2018

Closes #4676.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
@23Skidoo

LGTM.

@@ -201,20 +202,22 @@ instance Binary SubComponentTarget
-- the available packages (and their locations).
--
readTargetSelectors :: [PackageSpecifier (SourcePackage (PackageLocation a))]
-> Maybe ComponentKindFilter

This comment has been minimized.

@23Skidoo

23Skidoo Jul 27, 2018

Member

Please add a comment here explaining what this parameter does.

@23Skidoo

23Skidoo Jul 27, 2018

Member

Please add a comment here explaining what this parameter does.

@typedrat typedrat merged commit 5e51183 into haskell:master Jul 27, 2018

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@typedrat typedrat moved this from Needs Review to Done in Have new-build become build (GSOC2018) Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment