Disambiguate selectors by the command being used #5461
Merged
Conversation
[ci skip]
|
LGTM. |
| @@ -201,20 +202,22 @@ instance Binary SubComponentTarget | |||
| -- the available packages (and their locations). | |||
| -- | |||
| readTargetSelectors :: [PackageSpecifier (SourcePackage (PackageLocation a))] | |||
| -> Maybe ComponentKindFilter | |||
23Skidoo
Jul 27, 2018
Member
Please add a comment here explaining what this parameter does.
Please add a comment here explaining what this parameter does.
typedrat
merged commit 5e51183
into
haskell:master
1 check was pending
1 check was pending
typedrat
moved this from Needs Review
to Done
in Have new-build become build (GSOC2018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #4676.
Please include the following checklist in your PR: