/cabal

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate selectors by the command being used #5461

Merged
merged 3 commits into from Jul 27, 2018

Conversation

Reviewers

@23Skidoo 23Skidoo

Assignees

@typedrat typedrat

Labels
Projects
Done in Have new-build become build (GSOC2018)
Milestone
No milestone
2 participants
@typedrat @23Skidoo
@typedrat
Collaborator

typedrat commented Jul 27, 2018

Closes #4676.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.

@typedrat typedrat added the cabal-install: nix-local-build label Jul 27, 2018

@typedrat typedrat self-assigned this Jul 27, 2018

@typedrat typedrat added this to Needs Review in Have new-build become build (GSOC2018) Jul 27, 2018

@typedrat typedrat added the attention: needs-review label Jul 27, 2018

@23Skidoo

23Skidoo approved these changes Jul 27, 2018
View changes

LGTM.

cabal-install/Distribution/Client/TargetSelector.hs
@@ -201,20 +202,22 @@ instance Binary SubComponentTarget
-- the available packages (and their locations).
--
readTargetSelectors :: [PackageSpecifier (SourcePackage (PackageLocation a))]
-> Maybe ComponentKindFilter

This comment has been minimized.

Show comment
Hide comment
@23Skidoo

23Skidoo Jul 27, 2018

Member

Please add a comment here explaining what this parameter does.
Copy link
@23Skidoo

23Skidoo Jul 27, 2018

Member

Please add a comment here explaining what this parameter does.
@typedrat
Add comment explaining filter parameter 
[ci skip]
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
be362ee

@typedrat typedrat merged commit 5e51183 into haskell:master Jul 27, 2018
1 check was pending

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@typedrat typedrat moved this from Needs Review to Done in Have new-build become build (GSOC2018) Jul 27, 2018

@fgaz fgaz referenced this pull request Jul 27, 2018

Closed

`cabal repl` fails on package with Library and Executable #4602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment