Allow arguments to be passed to Setup.hs haddock for build-type:configure
#5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigure` In the course of 4466310 (see haskell#5526) the `Setup.hs haddock` CLI was extended to allow component ids to be passed as positional arguments. However, `autoconfUserHooks` which is used in case of `build-type: Configure` wasn't updated accordingly, and consequently this caused `new-haddock` to break for packages using `Configure`. cc @alexbiehl Fixes haskell#5503
4 tasks
|
Good catch! |
alexbiehl
approved these changes
Sep 8, 2018
hvr
added a commit
that referenced
this pull request
Sep 8, 2018
|
already cherry-picked to 2.4 via 3d2b9d0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of 4466310 (see #5526) the
Setup.hs haddockCLI was extended to allow component ids to be passedas positional arguments. However,
autoconfUserHookswhich is used incase of
build-type: Configurewasn't updated accordingly, and consequentlythis caused
new-haddockto break for packages usingConfigure.cc @alexbiehl
Fixes #5503