Skip to content

Use ProjectFlags to define CleanCmd#9356

Merged
mergify[bot] merged 4 commits into
haskell:masterfrom
shapr:6816.cmdclean-project-flags
Oct 25, 2023
Merged

Use ProjectFlags to define CleanCmd#9356
mergify[bot] merged 4 commits into
haskell:masterfrom
shapr:6816.cmdclean-project-flags

Conversation

@shapr
Copy link
Copy Markdown
Contributor

@shapr shapr commented Oct 20, 2023 •
edited
Loading

Reduce duplication of project flag handling, fixes #6816

The nearly identical PR for #7439 was used as a guide for this PR.

@shapr @exarkun
Use ProjectFlags to define CleanCmd
4771b9c 
The nearly identical PR for haskell#7439 was used as a guide for this PR.
The point of this PR is to reduce the duplication of project flag
handling.

Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
geekosaur
geekosaur approved these changes Oct 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the impression NamedFieldPuns is not well liked here, but otherwise it's okay.

@ulysses4ever
Copy link
Copy Markdown
Collaborator

ulysses4ever commented Oct 20, 2023

Thanks for the contribution!

I'm fine with field puns but it's strange to see it turned on together with wildcards -- their purpose largely intersects. Also, where are puns used? I couldn't spot it when skimming the text of the patch.

@exarkun
Copy link
Copy Markdown
Collaborator

exarkun commented Oct 20, 2023

Thanks for the contribution!

I'm fine with field puns but it's strange to see it turned on together with wildcards -- their purpose largely intersects. Also, where are puns used? I couldn't spot it when skimming the text of the patch.

Just in the definition of cleanAction, unpacking flagProjectName. Happy to remove the use of this extension if that's preferred, we just copied the style from CmdOutdated.hs

@ulysses4ever
Copy link
Copy Markdown
Collaborator

ulysses4ever commented Oct 20, 2023

Oh, I see now. Yeah, for consistency, it'd make sense to replace it with wildcards, I think. But only because of that. I personally prefer puns to wildcards.

ulysses4ever
ulysses4ever approved these changes Oct 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@exarkun
Copy link
Copy Markdown
Collaborator

exarkun commented Oct 23, 2023

Thanks for the reviews!

Per the contributor guide, now labeling for merge.

@exarkun exarkun added the squash+merge me Tell Mergify Bot to squash-merge label Oct 23, 2023
@ulysses4ever
Copy link
Copy Markdown
Collaborator

ulysses4ever commented Oct 23, 2023

@exarkun thank you! ❤️

@mergify mergify Bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 25, 2023
@mergify mergify Bot merged commit 0bab7cb into haskell:master Oct 25, 2023
@shapr shapr deleted the 6816.cmdclean-project-flags branch November 8, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees

No one assigned

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use ProjectFlags in CmdClean

4 participants

@shapr @ulysses4ever @exarkun @geekosaur