Various cabal-install init improvements #979

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
@byorgey
Member

byorgey commented Jul 24, 2012

  • Add support for default-language field, and bump min Cabal version to >=1.10
  • Improved error reporting
  • Bug fixes: --no-comments flag now works, and don't clobber existing files

Brent Yorgey added some commits Jul 24, 2012

Brent Yorgey
cabal init: improve error reporting when generating build-depends
This patch contains two improvements:
  1. Don't generate multiple warnings when the same module is
     imported multiple times.
  2. Get rid of spurious warnings about modules that could not be
     found, when those modules are in fact provided by the very
     package we are generating a .cabal file for.
@tibbe

This comment has been minimized.

Show comment Hide comment
@tibbe

tibbe Aug 11, 2012

Member

Sorry for the late reply. Would you mind fixing the one comment I made and rebase your patch series on top of the current HEAD (and thereby getting rid of the merge commit)? Thanks!

Member

tibbe commented Aug 11, 2012

Sorry for the late reply. Would you mind fixing the one comment I made and rebase your patch series on top of the current HEAD (and thereby getting rid of the merge commit)? Thanks!

@kosmikus

This comment has been minimized.

Show comment Hide comment
@kosmikus

kosmikus Aug 12, 2012

Contributor

I'm ok in principle with these to be merged.

Contributor

kosmikus commented Aug 12, 2012

I'm ok in principle with these to be merged.

@tibbe

This comment has been minimized.

Show comment Hide comment
@tibbe

tibbe Aug 13, 2012

Member

I've rebased the changes (fixing the issue I mentioned) and pushed them to master as 6bc5b91..b1bc941.

Member

tibbe commented Aug 13, 2012

I've rebased the changes (fixing the issue I mentioned) and pushed them to master as 6bc5b91..b1bc941.

@tibbe tibbe closed this Aug 13, 2012

@byorgey

This comment has been minimized.

Show comment Hide comment
@byorgey

byorgey Aug 14, 2012

Member

Ah, thanks for taking care of this, I've been away on vacation.

Member

byorgey commented Aug 14, 2012

Ah, thanks for taking care of this, I've been away on vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment