Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Directory does not infer Safe on old GHC #30

Closed
glguy opened this issue Aug 12, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@glguy
Copy link
Contributor

commented Aug 12, 2015

It appears that directory no longer asserts that it is TRUSTWORTHY as of version 1.2.3.0. This is fine for GHC 7.10 where the module infers that it is Safe. Unfortunately this is not the case on older version of GHC. A TRUSTWORTHY pragma is still necessary for these older version.

Using GHC 7.8.4:

System/Directory.hs:117:1:
    Foreign: Can't be safely imported! The module itself isn't safe.

Rufflewind added a commit to Rufflewind/directory that referenced this issue Aug 12, 2015

Restore the Trustworthy pragma for GHC < 7.10
This partly reverts 3177ec.

Fixes haskell#30.

@Rufflewind Rufflewind added the bug label Aug 12, 2015

david-christiansen added a commit to david-christiansen/Idris-dev that referenced this issue Aug 14, 2015

Blacklist directory 1.2.3.0
This is to work around an issue with directory on older GHCs.

See haskell/directory#30

david-christiansen added a commit to david-christiansen/Idris-dev that referenced this issue Aug 14, 2015

Blacklist directory 1.2.3.0
This is to work around an issue with directory on older GHCs.

See haskell/directory#30
@Tarrasch

This comment has been minimized.

Copy link

commented Aug 14, 2015

Also causing Travis build failure for Tarrasch/yesod-text-markdown#13, I think. Travis logs

glguy added a commit to glguy/directory that referenced this issue Aug 14, 2015

bgamari pushed a commit to bgamari/directory that referenced this issue Jul 29, 2016

quickSafe: do not call show on already escaped output (haskell#30)
This output:

   *** Failed! ... QFilePath "/\\?/a:a"

is much easier to digest than:

   "*** FAILED! ... \NQFILEPATH \"/\\\\?/A:A\"\N"

bgamari pushed a commit to bgamari/directory that referenced this issue Jul 29, 2016

Merge pull request haskell#31 from thomie/output
quickSafe: do not call show on already escaped output (haskell#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.