Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cbits/directory.c file #50

Closed
hvr opened this issue Apr 19, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@hvr
Copy link
Member

commented Apr 19, 2016

or more generally rethink how to handle the cbits in future, they seem kinda redundant by now

this includes figuring out if there's anyone depending on the .h files that may break...

@Rufflewind

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

I posted about this in the past but got no responses or complaints.

I think they can be replaced with hsc2hs.

Would removing them require bumping the major version?

@hvr

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2016

IMHO even hsc2hs is overkill here, just plain CapiFFI would probably suffice

@Rufflewind

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

IMHO even hsc2hs is overkill here, just plain CapiFFI would probably suffice

Wouldn't that require dropping support for GHC 7.4?

@hvr

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2016

Wouldn't that require dropping support for GHC 7.4?

No. Evidence: unix makes extensive use of CapiFFI and works with GHC 7.4 :-)

See also https://ghc.haskell.org/trac/ghc/wiki/LanguagePragmaHistory

@Rufflewind

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

Oh oops, I saw it in the release notes for 7.6 and thought it was introduced then.

@hvr

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2016

@Rufflewind yeah, that's been a cause of common confusion. There's quite a few who came to believe that CapiFFI excludes GHC 7.4

@Rufflewind

This comment has been minimized.

Copy link
Member

commented Apr 27, 2016

Based on a few Google searches, I don't think anyone uses the header or any of its functions, so I'll remove them and bump only the minor version.

(I also forgot that I had already removed the dependence on the C bits in the library code, so all I have to do now is to actually delete them.)

Rufflewind added a commit to Rufflewind/directory that referenced this issue Apr 27, 2016

@Rufflewind Rufflewind self-assigned this Apr 30, 2016

@Rufflewind Rufflewind added this to the 1.2.7.0 milestone Apr 30, 2016

Rufflewind added a commit that referenced this issue May 11, 2016

Remove deprecated C bits
See also: 7d36863

Fixes #50.

Rufflewind added a commit to Rufflewind/directory that referenced this issue Jun 13, 2016

bgamari pushed a commit to bgamari/directory that referenced this issue Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.