New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better get directory contents #17

Merged
merged 4 commits into from Feb 17, 2015

Conversation

Projects
None yet
2 participants
@snoyberg
Contributor

snoyberg commented Feb 17, 2015

Implements a fix for the stack overflow described in:

https://ghc.haskell.org/trac/ghc/ticket/9266

snoyberg added some commits Feb 17, 2015

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Feb 17, 2015

Contributor

@hvr Looks like the 7.4 builds are failing for other reasons, and therefore shouldn't prevent this being merged. Are you opposed to me removing 7.4 from the Travis config so we stop getting false negatives?

Contributor

snoyberg commented Feb 17, 2015

@hvr Looks like the 7.4 builds are failing for other reasons, and therefore shouldn't prevent this being merged. Are you opposed to me removing 7.4 from the Travis config so we stop getting false negatives?

@hvr

This comment has been minimized.

Show comment
Hide comment
@hvr

hvr Feb 17, 2015

Member

Well, you'd also have to update the lower bound on base in the cabal file... obviously :-)

However, I haven't looked at the code, but would it be difficult to simply disambiguate the catch-use to retain base-4.5-compat?

System/Directory.hs:402:28:
  Ambiguous occurrence `catch'
  It could refer to either `System.IO.Error.catch',
  imported from `System.IO.Error' at System/Directory.hs:83:1-22
  or `E.catch',
  imported from `Control.Exception.Base' at System/Directory.hs:85:1-34
Member

hvr commented Feb 17, 2015

Well, you'd also have to update the lower bound on base in the cabal file... obviously :-)

However, I haven't looked at the code, but would it be difficult to simply disambiguate the catch-use to retain base-4.5-compat?

System/Directory.hs:402:28:
  Ambiguous occurrence `catch'
  It could refer to either `System.IO.Error.catch',
  imported from `System.IO.Error' at System/Directory.hs:83:1-22
  or `E.catch',
  imported from `Control.Exception.Base' at System/Directory.hs:85:1-34
@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Feb 17, 2015

Contributor

I tried fixing that already and it just reveals another problem. I'll push
that change so there's a clear record of that problem.

On Tue, Feb 17, 2015, 2:22 PM Herbert Valerio Riedel <
notifications@github.com> wrote:

Well, you'd also have to update the lower bound on base in the cabal
file... obviously :-)

However, I haven't looked at the code, but would it be difficult to simply
disambiguate the catch-use to retain base-4.5-compat?

System/Directory.hs:402:28:
Ambiguous occurrence catch' It could refer to eitherSystem.IO.Error.catch',
imported from System.IO.Error' at System/Directory.hs:83:1-22 orE.catch',
imported from `Control.Exception.Base' at System/Directory.hs:85:1-34


Reply to this email directly or view it on GitHub
#17 (comment).

Contributor

snoyberg commented Feb 17, 2015

I tried fixing that already and it just reveals another problem. I'll push
that change so there's a clear record of that problem.

On Tue, Feb 17, 2015, 2:22 PM Herbert Valerio Riedel <
notifications@github.com> wrote:

Well, you'd also have to update the lower bound on base in the cabal
file... obviously :-)

However, I haven't looked at the code, but would it be difficult to simply
disambiguate the catch-use to retain base-4.5-compat?

System/Directory.hs:402:28:
Ambiguous occurrence catch' It could refer to eitherSystem.IO.Error.catch',
imported from System.IO.Error' at System/Directory.hs:83:1-22 orE.catch',
imported from `Control.Exception.Base' at System/Directory.hs:85:1-34


Reply to this email directly or view it on GitHub
#17 (comment).

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Feb 17, 2015

Contributor

Never mind, it was a bug with the Gold linker, which I worked around for testing. This looks good to merge actually.

Contributor

snoyberg commented Feb 17, 2015

Never mind, it was a bug with the Gold linker, which I worked around for testing. This looks good to merge actually.

@hvr

This comment has been minimized.

Show comment
Hide comment
@hvr

hvr Feb 17, 2015

Member

well... you should be able to merge it yourself :-)

Member

hvr commented Feb 17, 2015

well... you should be able to merge it yourself :-)

snoyberg added a commit that referenced this pull request Feb 17, 2015

@snoyberg snoyberg merged commit c51ade2 into haskell:master Feb 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@snoyberg snoyberg deleted the snoyberg:better-getDirectoryContents branch Feb 17, 2015

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Feb 17, 2015

Contributor

Hurrah. I'll move forward on master. Who should be in charge of releasing changes to Hackage?

Contributor

snoyberg commented Feb 17, 2015

Hurrah. I'll move forward on master. Who should be in charge of releasing changes to Hackage?

@hvr

This comment has been minimized.

Show comment
Hide comment
@hvr

hvr Feb 17, 2015

Member

...whoever takes responsibility for that particular release... :-)

For directory specifically, we should ideally try to make sure we've got everything in we want for GHC 7.10.1 (as ghc bundles a directory release). Otoh, it's no big deal either if we happen to have directory releases inbetween not bundled with GHC; it'll just give the cabal solver a bit more data to work with (and allow GHC 7.8.4 users to access new functionality early if they choose to) :-)

Member

hvr commented Feb 17, 2015

...whoever takes responsibility for that particular release... :-)

For directory specifically, we should ideally try to make sure we've got everything in we want for GHC 7.10.1 (as ghc bundles a directory release). Otoh, it's no big deal either if we happen to have directory releases inbetween not bundled with GHC; it'll just give the cabal solver a bit more data to work with (and allow GHC 7.8.4 users to access new functionality early if they choose to) :-)

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Feb 17, 2015

Contributor

If you don't mind, I think I'll leave the release to your discretion then, you certainly have more experience than I do timing releases with GHC.

Contributor

snoyberg commented Feb 17, 2015

If you don't mind, I think I'll leave the release to your discretion then, you certainly have more experience than I do timing releases with GHC.

bgamari pushed a commit to bgamari/directory that referenced this pull request Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment