Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
This PR aims to
In order to achieve these, I did
Also I did some small cleanup and fixed a space leak.
As for reviews, I guess it's easier to understand if you look at each commit in order. The first 9 commits implement the new incremental API, then 3dd58cf and bcb4595 make the API closer to v0.4. Other commits are small cleanup etc.
While I'm implementing
The new incremental API allows
This module was necessary to make the API closer to the previous version of ghc-events. I found it a bit strange that the
I made the
Now that we can move the I/O interface (read/writeEventLogFromFile) back to
The performance characteristics of
The runtime of
added a commit
this pull request
Mar 30, 2017
I made a change in threadscope for this refactor: haskell/ThreadScope@master...maoe:ghc-events-refactor. Basically nothing has changed.
Looks very nice, good job!
Admittedly I haven't tested this myself but given that the tests pass (and the fact that you seem to be using the library in your own code), I am quite confident in the correctness of the patch. I've had a couple of questions here and there but they're mostly minor things.
Thanks for reviewing this. I'm going to extend the Haddock comment on