Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision feed GUIDs aren't unique #683

Closed
dpwiz opened this issue Feb 21, 2018 · 1 comment

Comments

@dpwiz
Copy link
Contributor

@dpwiz dpwiz commented Feb 21, 2018

Consider following feed item:

<item>
    <title>refresht 0.1.1.0</title>
    <link>https://hackage.haskell.org/package/refresht-0.1.1.0/revisions</link>
    <guid isPermaLink="true">https://hackage.haskell.org/package/refresht-0.1.1.0/revisions</guid>
    <pubDate>Wed, 21 Feb 2018 15:21:20 UTC</pubDate>
    <description>&lt;i&gt;Revised by HiromiIshii, Wed Feb 21 15:21:20 UTC 2018.&lt;/i&gt;&lt;p&gt;Revision #1</description>
</item>

The link points to the human readable list of all revisions with a change log and that's great.
However, GUID field is the same link and actual revision number isn't present there, making GUID collisions very likely. Someone has to upload two revisions in same 48h window. And, anyway, they're not unique.

That means I'd have to consider extra fields like pubDate or parse description to check if I'm seeng a new revision or not.

I propose using the cabal URL for that revision as GUID. I.e. https://hackage.haskell.org/package/refresht-0.1.1.0/revision/1

@gbaz

This comment has been minimized.

Copy link
Contributor

@gbaz gbaz commented Feb 21, 2018

Fair point. Do you feel up to submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.