Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings while byte-compiling #105

Closed
jamorton opened this issue Dec 14, 2012 · 0 comments
Closed

Warnings while byte-compiling #105

jamorton opened this issue Dec 14, 2012 · 0 comments
Milestone

Comments

@jamorton
Copy link

Hi,

I get the following warnings while attempting to byte-compile haskell-mode in emacs 24:

Leaving directory `/Users/jonanin/.emacs.d/'

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/ghc-core.el at Fri Dec 14 15:45:31 2012
Entering directory `/Users/jonanin/.emacs.d/extra/haskell-mode/'

In ghc-core-create-core:
ghc-core.el:66:38:Warning: reference to free variable `core-buffer'

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-c.el at Fri Dec 14 15:45:31 2012

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-decl-scan.el at Fri Dec 14 15:45:31 2012

In end of data:
haskell-decl-scan.el:720:1:Warning: the function `fume-add-menubar-entry' is
    not known to be defined.

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-doc.el at Fri Dec 14 15:45:32 2012

In haskell-doc-mode:
haskell-doc.el:1421:17:Warning: `interactive-p' is an obsolete function (as of
    23.2); use `called-interactively-p' instead.

In end of data:
haskell-doc.el:1994:1:Warning: the following functions are not known to be defined:
    inferior-haskell-type, inferior-haskell-kind

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-font-lock.el at Fri Dec 14 15:45:32 2012

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-interactive-mode.el at Fri Dec 14 15:45:32 2012

In haskell-interactive-mode:
haskell-interactive-mode.el:63:18:Warning: reference to free variable
    `haskell-interactive-mode-map'
haskell-interactive-mode.el:65:21:Warning: assignment to free variable
    `haskell-interactive-mode'
haskell-interactive-mode.el:68:30:Warning: assignment to free variable
    `haskell-interactive-mode-history'
haskell-interactive-mode.el:70:30:Warning: assignment to free variable
    `haskell-interactive-mode-history-index'

In haskell-interactive-bring:
haskell-interactive-mode.el:123:32:Warning: function `find-if' from cl package
    called at runtime

In haskell-interactive-switch:
haskell-interactive-mode.el:135:25:Warning: function `find-if' from cl package
    called at runtime

In haskell-interactive-handle-line:
haskell-interactive-mode.el:170:35:Warning: reference to free variable
    `haskell-process-prompt-regex'

In haskell-interactive-mode-history-add:
haskell-interactive-mode.el:368:32:Warning: reference to free variable
    `haskell-interactive-mode-history'
haskell-interactive-mode.el:368:32:Warning: function `remove-if' from cl
    package called at runtime
haskell-interactive-mode.el:368:32:Warning: assignment to free variable
    `haskell-interactive-mode-history'
haskell-interactive-mode.el:369:9:Warning: assignment to free variable
    `haskell-interactive-mode-history-index'

In haskell-interactive-mode-history-toggle:
haskell-interactive-mode.el:374:17:Warning: reference to free variable
    `haskell-interactive-mode-history'
haskell-interactive-mode.el:376:19:Warning: reference to free variable
    `haskell-interactive-mode-history-index'
haskell-interactive-mode.el:379:11:Warning: assignment to free variable
    `haskell-interactive-mode-history-index'

In end of data:
haskell-interactive-mode.el:467:1:Warning: the following functions are not known to be defined:
    haskell-session-assign, haskell-session,
    haskell-session-interactive-buffer, haskell-process,
    haskell-process-queue-command, make-haskell-command,
    haskell-process-send-string, haskell-session-cabal-dir,
    haskell-session-current-dir

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-process.el at Fri Dec 14 15:45:33 2012

In haskell-process-suggest-remove-import:
haskell-process.el:446:40:Warning: `goto-line' used from Lisp code
That command is designed for interactive use only

In haskell-process-project-by-proc:
haskell-process.el:640:12:Warning: function `find-if' from cl package called
    at runtime

In haskell-process-set:
haskell-process.el:790:53:Warning: function `delete-if' from cl package called
    at runtime

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-session.el at Fri Dec 14 15:45:34 2012

In haskell-session-all-modules:
haskell-session.el:46:23:Warning: function `remove-if' from cl package called
    at runtime

In haskell-session-installed-modules:
haskell-session.el:65:49:Warning: reference to free variable
    `haskell-process-type'

In haskell-session-maybe:
haskell-session.el:96:11:Warning: assignment to free variable
    `haskell-session'

In haskell-session-from-buffer:
haskell-session.el:120:36:Warning: function `remove-if-not' from cl package
    called at runtime

In haskell-session-assign:
haskell-session.el:142:47:Warning: assignment to free variable
    `haskell-session'

In haskell-session-choose:
haskell-session.el:153:30:Warning: function `find-if' from cl package called
    at runtime

In haskell-session-clear:
haskell-session.el:158:47:Warning: assignment to free variable
    `haskell-session'

In haskell-session-make:
haskell-session.el:192:41:Warning: assignment to free variable
    `haskell-session'

In haskell-session-set:
haskell-session.el:268:53:Warning: function `delete-if' from cl package called
    at runtime

In end of data:
haskell-session.el:273:1:Warning: the following functions are not known to be defined:
    haskell-process-start, haskell-process-cd

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/haskell-show.el at Fri Dec 14 15:45:35 2012

Compiling file /Users/jonanin/.emacs.d/extra/haskell-mode/inf-haskell.el at Fri Dec 14 15:45:35 2012

In inferior-haskell-load-file:
inf-haskell.el:375:71:Warning: `end-of-buffer' used from Lisp code
That command is designed for interactive use only

In inferior-haskell-wrap-decl:
inf-haskell.el:430:37:Warning: reference to free variable
    `haskell-ds-start-keywords-re'

In inferior-haskell-type:
inf-haskell.el:536:31:Warning: `interactive-p' is an obsolete function (as of
    23.2); use `called-interactively-p' instead.

In inferior-haskell-kind:
inf-haskell.el:554:39:Warning: `interactive-p' is an obsolete function (as of
    23.2); use `called-interactively-p' instead.

In inferior-haskell-info:
inf-haskell.el:567:39:Warning: `interactive-p' is an obsolete function (as of
    23.2); use `called-interactively-p' instead.

In inferior-haskell-find-definition:
inf-haskell.el:593:24:Warning: reference to free variable
    `find-tag-marker-ring'
inf-haskell.el:596:24:Warning: `goto-line' used from Lisp code
That command is designed for interactive use only

In end of data:
inf-haskell.el:817:1:Warning: the following functions are not known to be defined: temp-directory,
    replace-in-string, haskell-ds-backward-decl,
    haskell-ds-forward-decl

Compiling no file at Fri Dec 14 15:45:36 2012

Although it does compile successfully, I figured it was worth reporting these.

akamch added a commit to akamch/haskell-mode that referenced this issue Jun 4, 2013
Fixes several compilation warnings (haskell#105)
hvr pushed a commit that referenced this issue Jun 5, 2013
Fixes several compilation warnings (#105)
hvr added a commit that referenced this issue Jun 5, 2013
hvr added a commit that referenced this issue Jun 9, 2013
This adds various `require`s and `declare-function`s

However, there's seems to be some code-smell here, as there are some
module-dep cycles which seem hard to break without reorganizing the
code. The most problematic module-dep cycle is between the following
modules:

- haskell-interactive-mode
- haskell-process
- haskell-session
- haskell-mode
hvr added a commit that referenced this issue Jun 9, 2013
This also drops Xemacs support from inf-haskell; We can't support
Xemacs unless somebody volunteers to take over Xemacs
maintainance/support.
@hvr hvr closed this as completed in fa5672f Jun 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant