Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor haskell-session-interactive-buffer so that it does not call switch-to-buffer-other-window #806

Open
19 tasks
gracjan opened this issue Aug 8, 2015 · 0 comments
Open
19 tasks

Refactor haskell-session-interactive-buffer so that it does not call switch-to-buffer-other-window #806

gracjan opened this issue Aug 8, 2015 · 0 comments
Labels
well-defined-task

Comments

@gracjan
Copy link
Contributor

gracjan commented Aug 8, 2015

Currently haskell-session-interactive-buffer calls switch-to-buffer-other-window and that is on the wrong level of abstraction. Callers of haskell-session-interactive-buffer should be refactored to call switch-to-buffer-other-window when it is needed. It is expected that most places will not need this call. haskell-session-interactive-buffer should not call switch-to-buffer-other-window.

These are call sites that need to be looked through if switch-to-buffer-other-window is needed:

  • ghci-script-mode.el:60: (let ((buffer (haskell-session-interactive-buffer (haskell-session)))
  • haskell-interactive-mode.el:308: (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:330: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:368: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:394: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:480: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:505: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:515:(defun haskell-session-interactive-buffer (s)
  • haskell-interactive-mode.el:949: (with-current-buffer (haskell-session-interactive-buffer (haskell-interactive-session))
  • haskell-interactive-mode.el:991: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:1054: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-interactive-mode.el:1093: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell-menu.el:155: (switch-to-buffer (haskell-session-interactive-buffer session))))
  • haskell-repl.el:111: (with-current-buffer (haskell-session-interactive-buffer session)
  • haskell.el:141: (kill-buffer (haskell-session-interactive-buffer session)))
  • haskell.el:199: (buffer (haskell-session-interactive-buffer (haskell-session))))
  • haskell.el:269: (haskell-session-interactive-buffer (haskell-session)))
  • haskell.el:286: (with-current-buffer (haskell-session-interactive-buffer (haskell-session))
  • haskell.el:376: (buffer (haskell-session-interactive-buffer session)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
well-defined-task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gracjan