Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc-9.0.1 support #285

Closed
wants to merge 10 commits into from
Closed

ghc-9.0.1 support #285

wants to merge 10 commits into from

Conversation

jneira
Copy link
Member

@jneira jneira commented Feb 22, 2021

  • Using ghc-api-compat head
  • The hard work was done by @fendor
  • Only 2 libs with allow-newer!

@jneira jneira requested a review from fendor February 22, 2021 22:46
@jneira jneira marked this pull request as draft February 22, 2021 22:46
@jneira
Copy link
Member Author

jneira commented Mar 11, 2021

ghc-api-compat does not suport ghc-8.4, time to drop support for it?

@fendor
Copy link
Collaborator

fendor commented Mar 11, 2021

I would rather try to attempt adding ghc-8.4 support to ghc-api-compat. I mean, how hard can that be? (famous last words)

@anka-213
Copy link

anka-213 commented Jun 5, 2021

Does any downstream consumers of this library support ghc-8.4?
Haskell Language Server/ghcide only supports ghc-8.6 and up, and judging from this list, there are not that many other users: https://packdeps.haskellers.com/reverse/hie-bios

@fendor
Copy link
Collaborator

fendor commented Jun 5, 2021

I am honestly not aware of any other consumers of this library

@anka-213
Copy link

anka-213 commented Jun 5, 2021

Should we just drop ghc-8.4 support then?

@fendor
Copy link
Collaborator

fendor commented Jun 5, 2021

If no one objects, sure

@jneira
Copy link
Member Author

jneira commented Jul 29, 2021

Superseded by #300

@jneira jneira closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants