Completely overhaul test-suite #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
commented
Aug 15, 2022
fendor
force-pushed
the
refactor/better-tests
branch
from
a65eb5a
to
56b3ce1
Compare
fendor
force-pushed
the
refactor/better-tests
branch
from
56b3ce1
to
98a6a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhault test-suite of hie-bios.
It became increasingly difficult to understand the test-suite, even though it is tiny!
So, we introduce an EDSL to define tests and a number of helper functions.
Additionally, we avoid nesting of predicate functions, and try to avoid indirective testing.
At least in my opinion, the test definitions are much cleaner, even though we have a bit more lines now.