string.h on some systems needs __USE_XOPEN2K8 defined

[rcallahan]

On older systems like CentOS, string.h needs __USE_XOPEN2K8 defined to import xlocale.h.

Adding CC-options: "-D__USE_XOPEN2K8" made the package build.

Building network-2.5.0.0...
Preprocessing library network-2.5.0.0...
In file included from dist/dist-sandbox-fe773bef/build/Network/BSD_hsc_utils.c:2:0:
/usr/include/string.h:548:5: error: unknown type name ‘__locale_t’
__locale_t __loc)
^
/usr/include/string.h:552:18: error: unknown type name ‘__locale_t’
size_t __n, __locale_t __loc)
^
compiling dist/dist-sandbox-fe773bef/build/Network/BSD_hsc_utils.c failed (exit code 1)

[tibbe]

I don't think we should add -D__USE_XOPEN2K8 unconditionally. Is there a way to detect if you're on these systems?

[rcallahan]

Yeah, I should clarify that that was not intended as a proposed patch in the general case. I'm not sure of a good way to do it, without knowing what other systems have this sort of feature in string.h.

[kazu-yamamoto]

We should use _GNU_SOURCE instead of __USE_XOPEN2K8: https://stackoverflow.com/questions/13879302/purpose-of-use-xopen2k8-and-how-to-set-it

And 64a3779 does it.

So, let's close this.