Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file descriptor in accept when exception happens #569

Closed

Conversation

andrewthad
Copy link
Contributor

Resolves #568

@kazu-yamamoto kazu-yamamoto self-requested a review August 9, 2023 01:16
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this pull request Aug 9, 2023
@kazu-yamamoto
Copy link
Collaborator

Rebased and merged.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept may leak file descriptor when thrown an asynchronous exception
2 participants