Conversation
sjakobi
left a comment
There was a problem hiding this comment.
Awesome! Having easy-to-run benchmarks is very useful to me right now! :)
README.markdown
Outdated
| To run benchmarks please clone and unpack | ||
| [test files](https://github.com/bos/text-test-data) | ||
| into `benchmarks/text-test-data`. |
There was a problem hiding this comment.
It took me a bit to figure out how to unpack the test files here. Including the actual commands might be useful:
$ git clone https://github.com/bos/text-test-data benchmarks/text-test-data
$ cd benchmarks/text-test-data
$ make
There was a problem hiding this comment.
Even better: Refer to tests-and-benchmarks.markdown.
There was a problem hiding this comment.
Can't we just have a submodule for this?
|
With some of the benchmarks I was wondering whether they would ever finish, given that |
@sjakobi Mind you that It would be nice to trim test data to a more manageable size, because it takes 700 Mb unpacked %) But let's do it separately from refurbishing benchmarks. |
|
I tweaked GC options to reduce noisiness of measurements. @tathougies @Lysxia @Boarders @parsonsmatt please review. |
|
@tathougies @Boarders @parsonsmatt unless there are comments / suggestions, I'd like to merge this by the end of the week. |
|
LGTM! |
This continues work started in #314 in order to simplify package structure.
criterionwith a lightweight drop-in replacementtasty-bench. CI build times decrease from 20 minutes to 5 minutes.tasty-benchdoes not depend ontext, so we can abandon a hack withhs-source-dirs: ../srcand benchmark a propertextpackage.String(extremely long and noisy because of huge memory allocation), and forByteString(which is nice, but doubles run time and is out of scope fortext). I removed them, now benchmarks can finish in around an hour.