Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhantomJS in Grafana add-on -- feature request #6

Closed
addons-assistant bot opened this issue Aug 8, 2018 · 6 comments

Comments

@addons-assistant
Copy link

commented Aug 8, 2018

@guiumb commented on Aug 8, 2018, 1:08 PM UTC:

Problem/Motivation

Grafana add-on allows you to create very readable panels and is a easy way to monitor all the data collected by Home Assistant.
Share panel capability as PNG image file provided by Grafana, unfortunatly, doesn't work because PhantomJS component was not included in currentrly add-on version 0.3.0.

Expected behavior

I think that sould be nice to have the Grafana export png capability also available in Hass.io platform.

Actual behavior

(What actually happened)

Steps to reproduce

Error log proveded by Grafana during a PNG export:

lvl=eror msg="executable not found" logger=rendering executable=/usr/share/grafana/tools/phantomjs/phantomjs
lvl=eror msg="Rendering failed - PhantomJS isn't included in arm build per default" logger=context userId=1 orgId=1 uname=admin error="PhantomJS executable not found"

Proposed changes

(If you have a proposed change, workaround or fix,
describe the rationale behind it)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This issue was moved by frenck from hassio-addons/repository/issues/81.

@addons-assistant

This comment has been minimized.

Copy link
Author

commented Aug 8, 2018

addons-assistant[bot] commented on Aug 8, 2018, 1:08 PM UTC:

👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

@addons-assistant

This comment has been minimized.

Copy link
Author

commented Aug 8, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

@CiquattroFPV

This comment has been minimized.

Copy link

commented Aug 27, 2018

Another way to reproduce this error is to go to the panel and click on share.. then click on Direct link rendered image..
image

image

@tjorim

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2018

Thanks, but we don't need to reproduce this as it isn't really an issue (if it is, it's at least a known issue). Grafana ditched PhantomJS because that project is abandoned. A new solution is in the works (upstream, it's actually a Grafana issue which does not only affect this add-on) and should replace this dependency.

@frenck What are your thoughts on including Grafana Image Renderer? It's a backend plugin for Grafana and needs to be included in the build (uses Node.js). Here's a bit more background info: grafana/grafana#11966. Ofcourse it's not a perfect solution but might be better than including PhantomJS.

@frenck

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

I'm not sure about Phantomjs... as it is not provided by the official Docker images of Grafana as well and, as mentioned by @tjorim, the PhantomJS project has been abandoned.

The "Grafana Image Renderer" is kinda new and I'm unsure if this is the direction Grafana is heading for at this point. So it is kinda hard to decide how to move forward on this issue at this point.

Maybe just install PhantomJS for now and see what the future brings?

@frenck frenck closed this in 8102efb Sep 27, 2018
@addons-assistant

This comment has been minimized.

Copy link
Author

commented Oct 27, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.