Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Scoped failure app #33

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

did commented Nov 7, 2011

Add tests for this functionality + fix tests suite for ruby 1.9.2 (replace lambda{} by proc {}).

Collaborator

josevalim commented Nov 7, 2011

There is one issue in this implementation. Warden users do not have access to all the places we call throw(:warden), so they would be able to pass the failure app option in just some occasions. The best implementation would probably be to add a scoped failure_app configuration and check it before calling the failure app. But that would also require the user to always pass the scope when calling throw(:warden).

@josevalim josevalim closed this Nov 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment