Fix for #warden_cookies #34

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants

As described in #20 and mentioned in my mail to hassox, #warden_cookies did not show up in the response. Now they do. :)

Collaborator

josevalim commented Nov 19, 2011

Shouldn't warden cookies just be a pointer to rack cookies? I am at first -1 on Warden implementing its own cookies serialization (even though it uses just rack methods, it doesn't seem warden's responsibilities).

That's a good point. I just implemented the feature how it was intended by the author, because it's rather convenient. But yes, you could easily call
Rack::Utils.set_cookie_header!(env['warden'].headers, 'something', {:value => 'else'}) directly in a warden strategy.

If you don't want to use this patch, please close it. And please remove the #warden_cookies method because it's not working and thus quite distracting.

josevalim closed this May 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment