Fix Rack Protocol implementation #63

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ptitfred
ptitfred commented Oct 9, 2012

From Rack SPEC :

  • The Body must respond to each and must only yield String values.
  • The keys must contain at least one dot, and should be prefixed uniquely.

    'warden' => 'warden.env'

Obviously, this breaks compatibility with existing applications.

Please note that the new key is a proposal.

@ptitfred ptitfred Respect Rack specification
From [SPEC](http://rack.rubyforge.org/doc/SPEC.html) :
- The Body must respond to each and must only yield String values.
- The keys must contain at least one dot, and should be prefixed uniquely.
    > 'warden' => 'warden.env'
8110e10
@josevalim
Collaborator

Unfortunately we cannot change the warden env key, it is way too incompatible. Could you please send a pull request that only changes the part invalid Body values? Thanks.

@josevalim josevalim closed this Mar 2, 2013
@ptitfred
ptitfred commented Mar 2, 2013

The only invalid part is the name of the Warden middleware itself. Can't provide a better fix.

But I can send a pull request amending the README to warn that Warden doesn't validate the Rack spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment