Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ClassIcons for Destro Warlock #183

Closed
PProvost opened this issue Mar 26, 2013 · 4 comments
Closed

Updated ClassIcons for Destro Warlock #183

PProvost opened this issue Mar 26, 2013 · 4 comments

Comments

@PProvost
Copy link

Hey haste,

I made some mods to classicons.lua so the same soul-shards icon system works for destruction lock burning embers.

You can see the edits here:
PProvost/ouf_quaiche@624d522

If you'd prefer I can do a clone and pull request, but given the elegance of your lua code I suspect you'll have a neater way to do it than I did.

Regards,

PProvost

@Rainrider
Copy link
Member

Burning embers could be partially full, soul shards are either full or empty. ClassIcons is an element to combine soul shards and the like as they share a similar update process. haste stated on wowinterface some time ago that he would like to combine death knight runes, altmana and some other class power resources that are currently being handled through statusbars in a single element like ClassIcons.

The warlock power bar in the standard ui can be found here: https://github.com/Ketho/wow-ui-source/blob/live/FrameXML/ShardBar.lua

@p3lim
Copy link
Member

p3lim commented Nov 15, 2015

No longer needed in Legion, see #260.

@haste
Copy link
Member

haste commented Nov 15, 2015

On one side Legion won't be out until Q2/Q3 next year, so closing the issue is kinda stupid, but on the other hand... We're still not supporting it after so many years. :P

@p3lim
Copy link
Member

p3lim commented Nov 15, 2015

Was adding the note mostly to link the two issues together so it won't be forgotten once Legion came :)

@p3lim p3lim mentioned this issue Nov 24, 2015
@p3lim p3lim closed this as completed Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants