Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java module system compliance #22

merged 22 commits into from Jun 22, 2019


Copy link

haster commented Jun 14, 2019

  • upgraded to java 11
  • moved/changed packages so every module now has a distinct 'parent' package
  • set new version to be 2.0.0
  • reworked java-chartjs-data and java-charts-serialization to be full jigsaw modules
  • java-chartjs-wicket can't be a module because not all dependencies are jigsaw-compliant but has an automatic module name at least
haster added 22 commits May 9, 2019
We needed to set the source level to 1.8 for java 8, otherwise it
wouldn't build but that is no longer applicable as we are now on java
All their dependencies have Automatic-Module-Name's at the very least
It is in the serialization module and packages should not be split over
Otherwise jackson can't do its work without using reflection to make the
method accessible.
This way the java-chartjs-data module is the .data package
This artifact splits the org.json package over itself and its direct dependency.
Now we can run tests without using a module-info
This doesn't come transitively through serialization anymore
They are not components but (wicket-style) resources so 'components' has
no place in the package name.
java.base is an implicit required module. I added it to make it explicit but it's not needed and can only engender confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.