Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and cancel buttons for analytic units #310

Merged
merged 8 commits into from May 20, 2019
Merged

Save and cancel buttons for analytic units #310

merged 8 commits into from May 20, 2019

Conversation

@rozetko
Copy link
Member

rozetko commented May 17, 2019

Multiple minor UI improvements which are too small for a separate PR

Changes

  • Disable Add analytic unit button on creation

  • Cancel creation
    image

  • Save button instead of auto-saving on blur (#312)
    image

  • Save button becomes active on config changes
    image

@rozetko rozetko changed the title UI improvements WIP: UI improvements May 17, 2019
rozetko added 3 commits May 20, 2019
@rozetko rozetko changed the title WIP: UI improvements UI improvements May 20, 2019
@rozetko rozetko marked this pull request as ready for review May 20, 2019
@rozetko rozetko requested review from jonyrock, VargBurz and amper43 May 20, 2019
fix
@rozetko rozetko merged commit d965d0b into master May 20, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rozetko rozetko deleted the ui-improvements branch May 20, 2019
@jonyrock jonyrock changed the title UI improvements UI improvements for analytic units buttons May 20, 2019
@jonyrock jonyrock changed the title UI improvements for analytic units buttons UI improvements: cancel and save buttons for analytic units May 20, 2019
@jonyrock jonyrock changed the title UI improvements: cancel and save buttons for analytic units Save and cancel and buttons for analytic units May 20, 2019
@jonyrock jonyrock changed the title Save and cancel and buttons for analytic units Save and cancel buttons for analytic units May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.