Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept various URL inputs #416

Closed
sankerust opened this Issue Feb 14, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@sankerust
Copy link
Contributor

sankerust commented Feb 14, 2019

Recently there was an issue, where GRAFANA_URL provided by the user was not accepted by hastic, since it had a slash (/) at the end of the URL.
"http://localhost:8000/"
instead of:
"http://localhost:8000"

resulted in this error:
Data kit: got response 404, message: Request failed with status code 404

We should figure out a way to accept various URL inputs, to avoid such issues in future.

@jonyrock

This comment has been minimized.

Copy link
Contributor

jonyrock commented Feb 14, 2019

I think we can also strip whitespaces from the string

@rozetko rozetko closed this in #429 Feb 24, 2019

rozetko added a commit that referenced this issue Feb 24, 2019

rozetko added a commit that referenced this issue Feb 24, 2019

Hotfix for #416 (#429)
- check for empty grafanauUrl

rozetko added a commit that referenced this issue Feb 25, 2019

Hotfix for #416 (#429):
- support ip:port scheme
- url-parse -> url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.