Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue or drop learning task on new learning task #664

Closed
jonyrock opened this issue May 19, 2019 · 1 comment · Fixed by #669
Closed

Queue or drop learning task on new learning task #664

jonyrock opened this issue May 19, 2019 · 1 comment · Fixed by #669

Comments

@jonyrock
Copy link
Contributor

@jonyrock jonyrock commented May 19, 2019

If there is a running learning task, then it is a normal behavior that hastic-server receive a new learning task. Now we shit our pants with Can't start learning when it's already started error.

We should handle it correctly: either drop the running task or add the new learning task to a queue.

@jonyrock

This comment has been minimized.

Copy link
Contributor Author

@jonyrock jonyrock commented May 19, 2019

It's fine to make a simple implementation and then make an issue here on github about improvements.

@jonyrock jonyrock changed the title Queue or drop learning task on new learning Queue or drop learning task on new learning task May 19, 2019
@amper43 amper43 closed this in #669 May 20, 2019
amper43 added a commit that referenced this issue May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.