Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CI vs RPM build #317

Merged
merged 43 commits into from Feb 26, 2019

Conversation

Projects
None yet
3 participants
@amper43
Copy link
Contributor

amper43 commented Dec 11, 2018

added:

  • rpm spec
  • dockerfile for rpmbuilder container
  • hasic service
  • makefile for CI

amper43 added some commits Dec 11, 2018

fix
fix
Show resolved Hide resolved Makefile Outdated
Show resolved Hide resolved build/rpm_build/Dockerfile Outdated
Show resolved Hide resolved build/rpm_build/hastic-server.spec Outdated

amper43 added some commits Dec 13, 2018

fix
fix
fix
fix
fix

@jonyrock jonyrock changed the title WIP: ci rpm build WIP: CI vs RPM build Dec 13, 2018

Makefile Outdated
-e "NODE_VERSION=6.14.0" \
-e "RPM_NODE_VERSION=6" \
-e "HASTIC_RELEASE_VERSION=`cat server/package.json| jq -r .version | sed 's/-/_/g'`" \
amper43/hastic-rpmbuilder rpmbuild -ba rpm/hastic-server.spec

This comment has been minimized.

@rozetko

rozetko Dec 13, 2018

Member

@jonyrock we should create a dockerhub repo for it: hastic/rpmbuilder

This comment has been minimized.

@jonyrock

jonyrock Dec 13, 2018

Contributor

@rozetko do we really need this? why can`t we create a docker file on this repo?

This comment has been minimized.

@rozetko

rozetko Dec 14, 2018

Member

@jonyrock I don't know if it's a good idea to build the same image every time we make a release

amper43 added some commits Dec 13, 2018

fix
services:
- docker


This comment has been minimized.

@jonyrock

jonyrock Dec 13, 2018

Contributor
Suggested change
docker run --rm -v `pwd`/server:/root/rpmbuild/server \
-v `pwd`/analytics:/root/rpmbuild/analytics \
-v `pwd`/build/rpmbuild:/root/rpmbuild/rpm \
-v `pwd`/dist/RPMS_6:/root/rpmbuild/RPMS \

This comment has been minimized.

@jonyrock
Makefile Outdated
-e "NODE_VERSION=6.14.0" \
-e "RPM_NODE_VERSION=6" \
-e "HASTIC_RELEASE_VERSION=`cat server/package.json| jq -r .version | sed 's/-/_/g'`" \
amper43/hastic-rpmbuilder rpmbuild -ba rpm/hastic-server.spec

This comment has been minimized.

@jonyrock

jonyrock Dec 13, 2018

Contributor

@rozetko do we really need this? why can`t we create a docker file on this repo?

@@ -0,0 +1,3 @@
all:
docker build -t amper43/hastic-rpmbuilder .
docker push amper43/hastic-rpmbuilder

This comment has been minimized.

@jonyrock

jonyrock Dec 13, 2018

Contributor

please stop using apmer43

amper43 added some commits Jan 25, 2019

fix
fix
fix
Makefile Outdated
-v `pwd`/analytics:/root/rpmbuild/analytics \
-v `pwd`/build/rpmbuild:/root/rpmbuild/rpm \
-v `pwd`/dist/RPMS_8:/root/rpmbuild/RPMS \
-e "NODE_VERSION=v8.0.0" \
-e "RPM_NODE_VERSION=8" \
-e "HASTIC_RELEASE_VERSION=`cat server/package.json| jq -r .version | sed 's/-/_/g'`" \
amper43/hastic-rpmbuilder rpmbuild -ba rpm/hastic-server.spec
amper43/hastic-rpmbuilder bash #rpmbuild -ba rpm/hastic-server.spec

This comment has been minimized.

@jonyrock

jonyrock Feb 20, 2019

Contributor

amper ?

@rozetko rozetko merged commit 5263a9c into master Feb 26, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rozetko rozetko deleted the ci-#178-rpm branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.