Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More info in webhooks #382 #436

Merged
merged 16 commits into from Feb 26, 2019

Conversation

Projects
None yet
2 participants
@amper43
Copy link
Contributor

amper43 commented Feb 25, 2019

fixes #382
fixes #441

@amper43 amper43 added the server label Feb 25, 2019

@amper43 amper43 self-assigned this Feb 25, 2019

@amper43 amper43 requested a review from rozetko Feb 25, 2019

Show resolved Hide resolved analytics/.vscode/launch.json Outdated

amper43 added some commits Feb 26, 2019

if(negativeMsg) {
negativeAction(negativeMsg);
if(negativeArgs) {
if(!(negativeArgs instanceof Array)) {

This comment has been minimized.

@rozetko

rozetko Feb 26, 2019

Member

maybe it would be prettier to write !_.isArray(negativeArgs)
But I'm not sure

amper43 added some commits Feb 26, 2019

@rozetko rozetko merged commit 0539079 into master Feb 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rozetko rozetko deleted the more-info-in-webhooks-#382 branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.