Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e test #28

Open
tirumaraiselvan opened this issue Mar 16, 2018 · 1 comment
Open

Improve e2e test #28

tirumaraiselvan opened this issue Mar 16, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@tirumaraiselvan
Copy link
Collaborator

tirumaraiselvan commented Mar 16, 2018 •
edited
Loading

Currently, the e2e test fails when the following two resources already exist:

Error from server (AlreadyExists): error when creating "STDIN": customresourcedefinitions.apiextensions.k8s.io "remotes.gitkube.sh" already exists
Error from server (AlreadyExists): error when creating "STDIN": clusterrolebindings.rbac.authorization.k8s.io "gitkube" already exists

For the CRD, we just need to ignore the error and for clusterrolebindings we can just use the test namespace name.
@shahidhk shahidhk added the good first issue Good for newcomers label Mar 16, 2018
@tirumaraiselvan tirumaraiselvan mentioned this issue Mar 16, 2018
Open
@tirumaraiselvan
Copy link
Collaborator Author

Also see #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shahidhk @tirumaraiselvan