New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update checker bottom-bar hiding the run button under sql tab #271

Closed
karthikvt26 opened this Issue Aug 8, 2018 · 9 comments

Comments

Projects
None yet
8 participants
@karthikvt26
Copy link
Contributor

karthikvt26 commented Aug 8, 2018

The update checker bottom bar is hiding the Run button on SQL page. PFA the screenshot of the same.

The update checker bar height need to be decreased a little and then proper CSS need to be added for it not to cover any important content.

screenshot 410

@praveenweb praveenweb added the c/console label Aug 8, 2018

shahidhk pushed a commit to shahidhk/graphql-engine that referenced this issue Sep 11, 2018

Merge pull request hasura#271 from hasura/issue-270
updated for create/delete user and custom provider hooks (Fix hasura#270)

@dsandip dsandip added the k/bug label Sep 21, 2018

@shahidhk shahidhk changed the title Update checker hiding the run button under sql tab update checker bottom-bar hiding the run button under sql tab Sep 26, 2018

@michizhou

This comment has been minimized.

Copy link
Contributor

michizhou commented Oct 2, 2018

Hi @karthikvt26, do you mind if I have a go at it? Also, do you have any preferences for how the CSS element should be formatted on the webpage? Let me know!

@shahidhk

This comment has been minimized.

Copy link
Member

shahidhk commented Oct 3, 2018

@michizhou It should appear as a footer, not overlaying anything. @karthikvt26 Can provide specific info.

@michizhou

This comment has been minimized.

Copy link
Contributor

michizhou commented Oct 5, 2018

@karthikvt26 Could you provide some more context on the repo path for the file that contains the CSS elements for the SQL tab you referenced in the issue description? I would also appreciate having other important information that could help me with tackling this issue. Thanks!

akshitbhalla added a commit to akshitbhalla/graphql-engine that referenced this issue Oct 7, 2018

@sdabhi23

This comment has been minimized.

Copy link
Contributor

sdabhi23 commented Oct 7, 2018

@shahidhk @karthikvt26 any suggestions on how I can reproduce the issue to test if the CSS fix is working?

@akshitbhalla

This comment has been minimized.

Copy link
Contributor

akshitbhalla commented Oct 7, 2018

Hi, I came across this issue while working with the graphql-engine myself and have been working on a fix too.

Is it alright if I go ahead and make a pull request for the same?

@akshitbhalla

This comment has been minimized.

Copy link
Contributor

akshitbhalla commented Oct 7, 2018

Okay, I'm going ahead and making the pull request so you can all see the changes I made to the repo.

This is a link to the sandbox in which I was trying to replicate the issue and fix it.

michizhou added a commit to michizhou/graphql-engine that referenced this issue Oct 7, 2018

michizhou added a commit to michizhou/graphql-engine that referenced this issue Oct 7, 2018

michizhou added a commit to michizhou/graphql-engine that referenced this issue Oct 7, 2018

michizhou added a commit to michizhou/graphql-engine that referenced this issue Oct 7, 2018

michizhou added a commit to michizhou/graphql-engine that referenced this issue Oct 7, 2018

@akshitbhalla

This comment has been minimized.

Copy link
Contributor

akshitbhalla commented Oct 8, 2018

@karthikvt26 @michizhou I couldn't help but notice that you raised a pull request 5 hours after I raised mine against this issue, with the same code changes.

What's going on?

@shahidhk

This comment has been minimized.

Copy link
Member

shahidhk commented Oct 8, 2018

@akshitbhalla @michizhou Don't worry about that, we'll figure this out.

@akshitbhalla

This comment has been minimized.

Copy link
Contributor

akshitbhalla commented Oct 8, 2018

Okay, thanks for the response.

@shahidhk shahidhk closed this in #665 Oct 8, 2018

shahidhk added a commit that referenced this issue Oct 8, 2018

michizhou added a commit to michizhou/graphql-engine that referenced this issue Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment