Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include 'range types' as a column type in console #3831

Closed
dukedave opened this issue Feb 5, 2020 · 1 comment
Closed

Don't include 'range types' as a column type in console #3831

dukedave opened this issue Feb 5, 2020 · 1 comment
Assignees

Comments

@dukedave
Copy link

@dukedave dukedave commented Feb 5, 2020

I propose that RANGE TYPES should not be selectable in the Add a new column select for column_type until #1082 is complete.

Without any support for the non-trivial range functions, I don't believe there is any reason to prefer them over two separate (upper-bound and lower-bound) columns of the corresponding type.


On seeing RANGE TYPES as an option, I naively added a column with tstzrange, and then had to reimplement later using individual upper and lower columns when I discovered that <@ (element is contained by) is not only unsupported, but is impossible (AFAICT) to implement using current GraphQL interface.

@rikinsk

This comment has been minimized.

Copy link
Contributor

@rikinsk rikinsk commented Feb 7, 2020

I would still leave the options there even though Hasura doesnt have the best support for them yet. Some users use the console as a DB management tool as well and it wouldnt be fair to limit that. Hasura is built to work with any database and shouldn't have a say in how users model their PG schema.

@rikinsk rikinsk closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.