Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console contributing guide is not clear about what env vars to set #517

Closed
shahidhk opened this issue Sep 22, 2018 · 1 comment · Fixed by #538
Closed

console contributing guide is not clear about what env vars to set #517

shahidhk opened this issue Sep 22, 2018 · 1 comment · Fixed by #538
Labels
c/console Related to console e/quickfix can be wrapped up in few hours
Milestone
v1.0.0-alpha23

Comments

@shahidhk
Copy link
Member

If I am trying to get console working locally, it is not clear which env vars I should be setting in .env

The current instructions assumes a lot of background knowledge and is confusing specifically around DATA_API_URL DEV_DATA_API_URL and some references to CLI.

We need to make this crystal clear for someone who only knows GraphQL engine endpoint.
@shahidhk shahidhk added c/console Related to console e/quickfix can be wrapped up in few hours labels Sep 22, 2018
@karthikvt26
Copy link
Contributor

I worked on a new draft for CONTRIBUTING.md. Will publish it by today.

@karthikvt26 karthikvt26 added this to the v1.0.0-alpha21 milestone Sep 26, 2018
@karthikvt26 karthikvt26 mentioned this issue Sep 26, 2018
Merged
13 tasks
shahidhk pushed a commit that referenced this issue Sep 27, 2018
@karthikvt26 @shahidhk
update console variables and contributing guide (close #517) (#538)
a9dc756 
Changes `consoleMode` variable templated by HGE to `server` and modified console to respect in the same way and adds a patch to continue working with the older HGEs

- [x] Server
- [x] Console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/console Related to console e/quickfix can be wrapped up in few hours
Projects
None yet
Milestone
v1.0.0-alpha23
Development

Successfully merging a pull request may close this issue.

update console variables and contributing guide (close #517) karthikvt26/graphql-engine
2 participants
@shahidhk @karthikvt26