Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add _inc and jsonb operators to update_mutation (close #159) #169

Merged
merged 6 commits into from Jul 20, 2018
Merged

add _inc and jsonb operators to update_mutation (close #159) #169

merged 6 commits into from Jul 20, 2018

Conversation

rakeshkky
Copy link
Member

No description provided.

@rakeshkky rakeshkky added k/enhancement New feature or improve an existing feature s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Jul 19, 2018
@rakeshkky rakeshkky requested a review from 0x777 July 19, 2018 09:22
@ecthiender ecthiender changed the title adds _inc and jsonb operators to update_mutation [closes #159] add _inc and jsonb operators to update_mutation (close #159) Jul 19, 2018
0x777
0x777 reviewed Jul 19, 2018
View reviewed changes
server/src-lib/Hasura/RQL/Types/SchemaCache.hs Outdated
@@ -183,6 +185,16 @@ data PGColInfo

$(deriveToJSON (aesonDrop 3 snakeCase) ''PGColInfo)

isIntegerType :: PGColInfo -> Bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define this in SQL/Types.hs?

@rakeshkky
define isIntergerType and isJSONBType in SQL/Types.hs
634d159
@rakeshkky
improve code
3543685 
1. define newtypes for SQL operations and SQL annotated types
2. use `bool` function for `case` patterns if necessary
0x777
0x777 previously approved these changes Jul 20, 2018
View reviewed changes
@0x777 0x777 added s/do-not-merge Do not merge this pull request to master and removed s/ok-to-merge Status: This pull request can be merged to master labels Jul 20, 2018
@0x777
Copy link
Member

0x777 commented Jul 20, 2018

@rakeshkky Let's add _append and _prepend instead of _concat.

Also, let's use the description from Postgres docs for the operators.
https://www.postgresql.org/docs/10/static/functions-json.html

@shahidhk shahidhk added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Jul 20, 2018
@shahidhk shahidhk merged commit 27e2d64 into hasura:master Jul 20, 2018
hasura-bot pushed a commit that referenced this pull request Jan 8, 2021
@hasura-bot
server: RQL code health
3948ca8 
This PR is a combination of the following other PRs:
- #169: move HasHttpManager out of RQL.Types
- #170: move UserInfoM to Hasura.Session
- #179: delete dead code from RQL.Types
- #180: move event related code to EventTrigger

GitOrigin-RevId: d97608d
hgiasac pushed a commit to hgiasac/graphql-engine that referenced this pull request Dec 19, 2023
@rakeshkky @hgiasac
Improve validation of filterable and orderable fields defined for a m…
6371cbc 
…odel (hasura#169)

GitOrigin-RevId: f8ae54377250f281cfe66d6022135f39682d7ef0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x777 0x777 0x777 approved these changes

Assignees
No one assigned
Labels
c/server Related to server k/enhancement New feature or improve an existing feature s/ok-to-merge Status: This pull request can be merged to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rakeshkky @0x777 @shahidhk