Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: update sample apps for codesandbox compatibility #2377

Merged
merged 4 commits into from Jun 14, 2019

Conversation

praveenweb
Copy link
Member

@praveenweb praveenweb commented Jun 14, 2019

Description

This PR updates sample apps with server endpoints hardcoded for quicker preview on codesandbox or other online editors.
Also added Edit on Codesandbox button for direct link to the sandbox URL.
Added package.json for static apps so that it can be rendered.

Affected components

  • Community Content

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@netlify
Copy link

netlify bot commented Jun 14, 2019

Deploy preview for hasura-docs ready!

Built with commit eaded57

https://deploy-preview-2377--hasura-docs.netlify.com

@netlify
Copy link

netlify bot commented Jun 14, 2019

Deploy preview for hasura-docs ready!

Built with commit 183fe68

https://deploy-preview-2377--hasura-docs.netlify.com

@shahidhk shahidhk changed the title update sample apps for codesandbox compatibility community: update sample apps for codesandbox compatibility Jun 14, 2019
@shahidhk shahidhk merged commit c4dd209 into hasura:master Jun 14, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2377.herokuapp.com is deleted

@praveenweb praveenweb deleted the codesandbox-compatibility branch August 1, 2019 12:49
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants