Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Joins: Create relationships across database and remote schemas (only server) #2392

Open
wants to merge 162 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@tirumaraiselvan
Copy link
Member

commented Jun 18, 2019

Preview

Please check #2395 for Remote Joins with console.

Description

Remote Joins will ensure independent and related types in Remote Schemas can be joined natively via Hasura.

Remote joins will work similar to table relationships. You can define a relationship by giving:

  • a name for the relationship
  • a join configuration from table fields to remote schema fields.

Affected components

  • Server
  • Console
  • Docs
  • Build System
  • Tests

Related Issues

#1225
#1846
#2461

Remaining steps:

  • Pass all tests
  • Change tests for breaking changes
  • Field level permissions
  • Add joining logic in websocket protocol
  • Update test dependencies in circleCI
  • Docs
  • Console (happening in #2395 )
  • Concurrency changes
  • Change error handling to collect all errors
  • Breaking support for remote interfaces and union types
  • Change query caching logic for concurrent executions
  • Run benchmarks

Steps to test and verify

The latest preview is available at https://hge-ci-pull-2395.herokuapp.com/
Please check the PR #2395 comments for the latest docker version.

Limitations, known bugs & workarounds

  • Transactions will not work for concurrent execution.
  • Enum types are not supported for JOIN columns

chrisdone and others added some commits Jun 3, 2019

Merge pull request #10 from chrisdone/insert-remote-relationships-and…
…-validation

Insert remote relationships and validation
Merge pull request #13 from tirumaraiselvan/update_remote_schema_test…
…_infra

add node graphql test server
Merge pull request #11 from tirumaraiselvan/validate_object_types
implement list and object validations (close #9)
@hasura-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

Review app for commit c12d47d deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-c12d47d4

@coco98 coco98 changed the title remote data relationships: create relationships across database and remote schemas Remote Joins: Create relationships across database and remote schemas Jun 20, 2019

@hasura-bot

This comment has been minimized.

Copy link

commented Jun 24, 2019

Review app for commit 2dc6ec9 deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-2dc6ec92

@hasura-bot

This comment has been minimized.

Copy link

commented Jun 24, 2019

Review app for commit f6be3b8 deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-f6be3b88

@hasura-bot

This comment has been minimized.

Copy link

commented Jun 25, 2019

Review app for commit ad7e69a deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-ad7e69a1

@hasura-bot

This comment has been minimized.

Copy link

commented Jul 1, 2019

Review app for commit 034cd3f deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-034cd3f5

@hasura-bot

This comment has been minimized.

Copy link

commented Jul 1, 2019

Review app for commit e5e0af6 deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-e5e0af66

@hasura-bot

This comment has been minimized.

Copy link

commented Jul 2, 2019

Review app for commit 70873f6 deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-70873f67

@hasura-bot

This comment has been minimized.

Copy link

commented Jul 2, 2019

Review app for commit 6d27beb deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-6d27beb6

tirumaraiselvan added some commits Jul 3, 2019

Merge remote-tracking branch 'upstream/master' into remote-relationsh…
…ips-v2

# Conflicts:
#	server/src-lib/Hasura/GraphQL/Execute.hs
#	server/src-lib/Hasura/GraphQL/RemoteServer.hs
#	server/src-lib/Hasura/GraphQL/Schema.hs
#	server/src-lib/Hasura/RQL/DDL/RemoteSchema.hs
#	server/src-lib/Hasura/RQL/Types/RemoteSchema.hs
#	server/src-lib/Hasura/RQL/Types/SchemaCache.hs
#	server/src-lib/Hasura/Server/App.hs
#	server/src-lib/Hasura/Server/Query.hs
#	server/tests-py/test_schema_stitching.py
@hasura-bot

This comment has been minimized.

Copy link

commented Jul 8, 2019

Review app for commit 89c6e5b deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-89c6e5b9

chrisdone and others added some commits Jul 8, 2019

@hasura-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

Review app for commit 0383652 deployed to Heroku: https://hge-ci-pull-2392.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2392-03836526

@tirumaraiselvan tirumaraiselvan changed the title Remote Joins: Create relationships across database and remote schemas Remote Joins: Create relationships across database and remote schemas (only server) Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.