Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom mutations through actions #3042

Draft
wants to merge 25 commits into
base: master
from
Draft

allow custom mutations through actions #3042

wants to merge 25 commits into from

Conversation

@0x777
Copy link
Member

0x777 commented Oct 6, 2019

I'll be pushing changes to this PR over the next couple of days. A high level overview of actions can be found in this PR's docs.

Updated: 23/10/2019

Tasks done:

  • defining custom types
  • sync actions
  • async actions
  • metadata export/import
  • http endpoint as action handlers
  • relationships

Remaining:

  • pg functions as action handlers
  • async action relationships
@netlify

This comment has been minimized.

Copy link

netlify bot commented Oct 6, 2019

Deploy preview for hasura-docs ready!

Built with commit 6944f42

https://deploy-preview-3042--hasura-docs.netlify.com

@0x777

This comment has been minimized.

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 6, 2019

Review app for commit a786aed deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-a786aed5

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 14, 2019

Review app for commit af6139e deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-af6139ec

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 14, 2019

Review app for commit 5d58513 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-5d58513d

@0x777 0x777 force-pushed the 0x777:actions branch from 5d58513 to 05684e8 Oct 15, 2019
0x777 and others added 4 commits Oct 15, 2019
@0x777 0x777 force-pushed the 0x777:actions branch from 4c1c861 to a7d72ac Oct 17, 2019
@0x777 0x777 force-pushed the 0x777:actions branch from 97c245e to 4462284 Oct 20, 2019
@0x777 0x777 force-pushed the 0x777:actions branch from e89e89f to 4bc8106 Oct 21, 2019
@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 21, 2019

Review app for commit 4bc8106 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-4bc81068

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 21, 2019

Review app for commit c86dcc4 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-c86dcc46

@hasura hasura deleted a comment from wawhal Oct 24, 2019
@hasura hasura deleted a comment from wawhal Oct 24, 2019
@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 24, 2019

Review app for commit ea0f8f7 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-ea0f8f70

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 24, 2019

Review app for commit a40b68e deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-a40b68e7

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 24, 2019

Review app for commit c33372a deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-c33372a8

@wawhal wawhal mentioned this pull request Oct 26, 2019
2 of 3 tasks complete
@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Oct 30, 2019

Review app for commit 2559837 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-25598377

@wawhal

This comment has been minimized.

Copy link
Contributor

wawhal commented Nov 12, 2019

Hey @0x777 I think I found a bug.

If my output type of any action is UserInfo, the server will not allow me to remove the type UserInfo from custom types. But if the output type is UserInfo!, the server lets me remove UserInfo from custom types.

Expected behaviour is that if any extension of UserInfo is used by an action, the server should not allow me to remove them from custom types.

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Dec 3, 2019

Review app for commit 1c9819a deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-1c9819ab

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Dec 10, 2019

Review app for commit aa02af1 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-aa02af1f

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Dec 10, 2019

Review app for commit 5a5ad19 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-5a5ad19c

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Dec 10, 2019

Review app for commit 1f6adac deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-1f6adacd

@hasura-bot

This comment has been minimized.

Copy link

hasura-bot commented Dec 11, 2019

Review app for commit 6944f42 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-6944f42d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.