Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix init command to generate correct config (fix #4036) #4038

Merged
merged 9 commits into from Mar 26, 2020
Merged

cli: fix init command to generate correct config (fix #4036) #4038

merged 9 commits into from Mar 26, 2020

Conversation

arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Mar 5, 2020 •
edited

Description

This PR fixes the init command to generate correct config.yaml based on the version. Also, add omitempty tags for the fields that needs to be omitted if empty value.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#4036

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Mar 5, 2020
@hasura-bot
Copy link
Contributor

Review app for commit 709f18e deployed to Heroku: https://hge-ci-pull-4038.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4038-709f18eb

@hasura-bot
Copy link
Contributor

Review app for commit 8b0b1d6 deployed to Heroku: https://hge-ci-pull-4038.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4038-8b0b1d6a

@hasura-bot
Copy link
Contributor

Review app for commit 096d73d deployed to Heroku: https://hge-ci-pull-4038.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4038-096d73da

@hasura-bot
Copy link
Contributor

Review app for commit 23ed13a deployed to Heroku: https://hge-ci-pull-4038.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4038-23ed13ae

@arvi3411301 arvi3411301 added this to the v1.2 milestone Mar 17, 2020
@hasura-bot
Copy link
Contributor

Review app for commit a8badcd deployed to Heroku: https://hge-ci-pull-4038.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4038-a8badcd4

@shahidhk shahidhk changed the title cli: fix init command to generate correct config.yaml cli: fix init command to generate correct config.yaml (fix #4036) Mar 26, 2020
@shahidhk shahidhk changed the title cli: fix init command to generate correct config.yaml (fix #4036) cli: fix init command to generate correct config (fix #4036) Mar 26, 2020
@shahidhk shahidhk merged commit 09e0e2f into hasura:master Mar 26, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4038.herokuapp.com is deleted

@shahidhk shahidhk deleted the issue-4036 branch March 26, 2020 03:24
anurag pushed a commit to anurag/graphql-engine that referenced this pull request Mar 26, 2020
@arvi3411301 @anurag
cli: fix init command to generate correct config (fix hasura#4036) (h…
7acdc60 
…asura#4038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

@marionschleifer marionschleifer Awaiting requested review from marionschleifer

Assignees

@shahidhk shahidhk

Labels
c/cli Related to CLI
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arvi3411301 @hasura-bot @shahidhk