Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull request template (close #473) #488

Merged
merged 18 commits into from Sep 20, 2018
Merged

add pull request template (close #473) #488

merged 18 commits into from Sep 20, 2018

Conversation

shark-h
Copy link
Member

@shark-h shark-h commented Sep 19, 2018

For #473

@shark-h shark-h changed the title Create PULL_REQUEST_TEMPLATE.md pr_template Sep 19, 2018
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shark-h please see the comments

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@shark-h shark-h changed the title pr_template pr_template and issue_template Sep 19, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-488.herokuapp.com

@shark-h
Copy link
Member Author

shark-h commented Sep 19, 2018

Added new demo gif as well.

@shahidhk shahidhk changed the title pr_template and issue_template add pr_template and issue_template (close #473) Sep 20, 2018
@shahidhk shahidhk changed the title add pr_template and issue_template (close #473) add pull request template (close #473) Sep 20, 2018
@shahidhk shahidhk merged commit a5ebd5a into hasura:master Sep 20, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-488.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-488.herokuapp.com

@shark-h shark-h deleted the pr_template branch September 21, 2018 09:52
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 12, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b6eb71a
Status:🚫  Build failed.

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants