Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable redux-dev-tools if present in dev mode (closes #606) #607

Merged
merged 3 commits into from Oct 5, 2018
Merged

enable redux-dev-tools if present in dev mode (closes #606) #607

merged 3 commits into from Oct 5, 2018

Conversation

kraynel
Copy link
Contributor

@kraynel kraynel commented Oct 1, 2018 •
edited

Description

Enables redux-dev-tools in development mode.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#606

Solution and Design

image

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@kraynel kraynel changed the title Enable redux-dev-tools if present in dev mode (fixes #606) Enable redux-dev-tools if present in dev mode (closes #606) Oct 1, 2018
@shahidhk shahidhk added the c/console Related to console label Oct 2, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-607.herokuapp.com

@shahidhk
Copy link
Member

shahidhk commented Oct 4, 2018

@praveenweb @karthikvt26 Please review!

@karthikvt26
Copy link
Contributor

karthikvt26 commented Oct 4, 2018 •
edited

@kraynel Thank you for the wonderful PR. It looks good 🏆. Can you also update the console README with this as an optional thing for development?

@karthikvt26
Copy link
Contributor

@kraynel any update on this?

@kraynel
Copy link
Contributor Author

kraynel commented Oct 5, 2018

@kraynel any update on this?

Of course, I'll try and commit that today.

karthikvt26
karthikvt26 approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk changed the title Enable redux-dev-tools if present in dev mode (closes #606) enable redux-dev-tools if present in dev mode (closes #606) Oct 5, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-607.herokuapp.com

@shahidhk shahidhk merged commit 5abd18a into hasura:master Oct 5, 2018
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @kraynel! 💪 🏆 All of us at Hasura ❤️ what you did.

We would love to send you some swag! 👕 Please allow us to do so by filling this form.

If you have any questions, ask us on our Discord & Twitter!

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-607.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

@karthikvt26 karthikvt26 karthikvt26 approved these changes

@praveenweb praveenweb Awaiting requested review from praveenweb

Assignees
No one assigned
Labels
c/console Related to console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kraynel @hasura-bot @shahidhk @karthikvt26