Update midi.c #18
Closed
Update midi.c #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated function Midi_BuildEvent because of malfunction and errors in PortMidi library. Tested with Notator and Cubase. News: - note on/off handling - running status accordinf to MIDI spec - sys ex events.
huth
requested changes
Dec 12, 2021
|
|
||
| // -- status byte | ||
| if (byte & 0x80) | ||
| if ((byte & 0x80) > 0) |
There was a problem hiding this comment.
This change does not make any sense. Or what's the difference to the previous behavior?
| { | ||
| if (byte >= 0xF8) | ||
| { | ||
|
|
There was a problem hiding this comment.
Unnecessary white space change, please avoid that.
| } | ||
|
|
||
| // -- data byte | ||
| else | ||
| { | ||
| if (processingSysex) | ||
| midimsg |= ((Uint32)byte) << shifts[bytesCollected++]; | ||
| if ((expectStatus == true) && (runningStatus >= 0x80) && (processingSysex == false)) { |
There was a problem hiding this comment.
Please follow the Hatari coding style when adding new code.
huth
pushed a commit
that referenced
this pull request
Dec 12, 2021
And add trace output for parsed MIDI events. Cleaned up version of a fix provided by FedeUlivi/federik0: #18 https://www.atari-forum.com/viewtopic.php?p=426400#p426400 + documentation update.
|
Fix has been committed by Eero here: https://git.tuxfamily.org/hatari/hatari.git/commit/?id=65551f7f0819fef503989a832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated function Midi_BuildEvent because of malfunction and errors in PortMidi library. Tested with Notator and Cubase.
News: