Symbolic map of SDLK_MINUS should use US minus scancode

[bbbradsmith]

This was part of #26 but rejected. I would like to re-propose it with a better explanation. (Apologies that this re-iterates post close comments on that PR.)

The default "Symbolic" key-mappings give 100% coverage of the US layout keyboard to US TOS, except for this one key.

There are several keys not on a US keyboard that are also provided some mapping, since they don't conflict, but the mapping here is explicitly QWERTY according to the comment just above it.

This change was rejected in PR #26 because it conflicts with the German mapping, but I believe that all of the default Symbolic mappings conflict with the German mapping where different than US layout, not just this one. Therefore I propose this key should use the US mapping, so that at least one layout 100% works with the default.

It seems that with default Symbolic settings with German host keyboard + German TOS we already have many mapping conflicts with the default keys, notably Y vs Z but many other places. Am I correct in believing this? I don't think it makes sense to cause SDLK_MINUS to work as expected for this case in only German, but have all its other mappings still wrong.

(I don't have a physical German keyboard to compare, though I can set my keyboard layout in Windows, and the results are what I'd expect to see given the code. Does what I describe match the behaviour with the physical keyboard as well?)

[huth]

Hi Brad! Sorry, I'm not going to change the mapping for this key. It has been like this for > 20 years now, and if we'd change this now, we'd might break the setup of a lot of other users, I guess.

Anyway, please just switch to the "scancode" mapping method instead. It should give you a much better experience than the "symbolic" mapping. And in the worst case, just create a mapping file like it is described in the doc/keymap-sample.txt file.

[bbbradsmith]

It feels bizarre that you keep telling me to switch to scancode mapping. I don't have a problem customizing Hatari. I'm not submitting this for the sake of my personal settings.

I'm trying to improve the user experience for the default setup, which is 1 key away from working perfectly for one common layout. If it was 1 key away from the German layout, I'd be suggesting to fix that one key to match the rest instead.

Anyway, if this is an impasse that's fine. I have another idea which I will submit later, but I still think this would be a useful change for many users.