NEO screenshot support for more modes still compatible with the format #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that hires palette is unavailable (and safer method of addressing it)
… (though we still have no FrameBuffer image data)
…ions and BPP, dump as much data as needed.
… of their colour information.
# Conflicts: # src/configuration.c # src/includes/configuration.h # src/screenConvert.c # src/screenSnapShot.c
…te suffix, create errors to diagnose when the screenshot can't be created
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #31 where it was heavily modified before merging I think due to a misunderstanding. I was not given a chance to respond before these modifications were made.
In that PR, I mentioned that for the edge case of screenshots that don't fit in the traditional NEO format, I made two small non-standard extensions to the file. However, I think this comment was mistaken to indicate that a large part of the code was intended for support of this, which it was not.
Most of the removed or edited code ended up removing support for TT and Falcon resolutions/modes which are still valid compatible NEO data. I am re-submitting the patch to restore this support, with the following changes:
To clarify what part of the code was originally introduced to support the non-standard extension, it was very minor, see this change:
Alternatively, #34 provides this patch + additional support for the XIMG format.