enable dedicated hwfifo for rp2#3451
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c86cbdc82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables dedicated hardware FIFO support for the RP2040 microcontroller, allowing more efficient USB data transfers by utilizing hardware FIFO buffers with byte-stride access.
Key changes:
- Adds RP2040-specific hardware FIFO configuration with byte-level access patterns
- Implements FIFO-based transfer mode alongside existing buffer-based transfers
- Reorganizes USB IP configuration sections in tusb_option.h for better clarity
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tusb_option.h | Reorganizes USB IP sections and adds RP2040 hardware FIFO configuration with byte-stride access |
| src/portable/raspberrypi/rp2040/rp2040_usb.h | Adds FIFO support to hw_endpoint struct with union for buffer/FIFO modes and updates function signatures |
| src/portable/raspberrypi/rp2040/rp2040_usb.c | Implements custom FIFO read/write functions and updates transfer logic to support both buffer and FIFO modes |
| src/portable/raspberrypi/rp2040/hcd_rp2040.c | Updates hw_endpoint_xfer_start calls to pass NULL for FIFO parameter (buffer mode) |
| src/portable/raspberrypi/rp2040/dcd_rp2040.c | Adds dcd_edpt_xfer_fifo function and updates existing dcd_edpt_xfer to pass NULL for FIFO parameter |
| src/common/tusb_fifo.c | Enhances stride_write/stride_read with byte-level access support and optimizes wrap-around handling for byte-stride |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in size
Changes <1% in size
No changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable dedicated hwfifo for rp2 port